Patch to EBookBackendCache

Discussion:

Jörgen Scheibengruber

2008-08-13 20:12:10 UTC

Hi,

here comes a patch for e-book-backend-cache.c. The method
e_book_backend_cache_set_time () currently allows you to set the
time exactly once, and will return failure later on. I don't
think this is intended behaviour --- at least it is not what
I would need in the google contacts backend. So this patch will
overwrite the old time-stamp when a new one is set instead.

PS: I'm not suscribed to the list ;-)

Br,
JÃ¶rgen

Srinivasa Ragavan

2008-08-14 02:51:40 UTC

Permalink

Looks fine to commit.

Some how, it feels to me that e-file-cache (_replace) should be
intelligent to do all this. Since it already does, get_object. It can be
more efficient.

-Srini.

Post by JÃ¶rgen Scheibengruber
Hi,
here comes a patch for e-book-backend-cache.c. The method
e_book_backend_cache_set_time () currently allows you to set the
time exactly once, and will return failure later on. I don't
think this is intended behaviour --- at least it is not what
I would need in the google contacts backend. So this patch will
overwrite the old time-stamp when a new one is set instead.
PS: I'm not suscribed to the list ;-)
Br,
Jörgen
_______________________________________________
Evolution-patches mailing list
http://mail.gnome.org/mailman/listinfo/evolution-patches

Jörgen Scheibengruber

2008-08-16 08:00:20 UTC

Permalink

Post by Srinivasa Ragavan
Looks fine to commit.
Some how, it feels to me that e-file-cache (_replace) should be
intelligent to do all this. Since it already does, get_object. It can be
more efficient.

Indeed. I can also add "e_file_cache_add_or_replace_object"[1]?

Br,
Jörgen

[1] Better name welcome...

Post by Srinivasa Ragavan
-Srini.